[adoption_osp_deploy] Remove unused undercloud ctlplane_vip#4019
Conversation
ciecierski
force-pushed
the
remove-undercloud-ctlplane-vip
branch
from
65dd448 to
d4b9eb4
Compare
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 11m 53s |
|
recheck |
|
recheck |
The `_ctlplane_vip` variable was set from `cifmw_adoption_osp_deploy_scenario.undercloud.ctlplane_vip` and injected into the undercloud os-net-config templates, but no service endpoints actually use this VIP -- they all use `_ctlplane_ip`. The dependency OSPRH-12150 (TLS-e for adoption) is now closed without needing the VIP. Remove the variable assignment from `prepare_undercloud.yml` and the VIP CIDR detection block plus address line from both the standard and BGP os-net-config templates. Related-Issue: #OSPRH-17418 Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Mikołaj Ciecierski <mikolaj.ciecierski@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
ciecierski
force-pushed
the
remove-undercloud-ctlplane-vip
branch
from
d4b9eb4 to
b01b624
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michburk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 56153d4
into
openstack-k8s-operators:main
The undercloud ctlplane_vip was set in scenario files but never used by any service endpoint — they all use ctlplane_ip instead. The consumer in ci-framework's adoption_osp_deploy role has been removed in openstack-k8s-operators/ci-framework#4019. This removes the now-unnecessary ctlplane_vip key from the undercloud section in all 12 scenario files. The overcloud VIPs in vips_data.yaml files are unrelated and remain untouched. Depends-On: openstack-k8s-operators/ci-framework#4019 Related-Issue: #OSPRH-17418 Co-authored-by: Cursor <cursoragent@cursor.com>
The undercloud ctlplane_vip was set in scenario files but never used by any service endpoint — they all use ctlplane_ip instead. The consumer in ci-framework's adoption_osp_deploy role has been removed in openstack-k8s-operators/ci-framework#4019. This removes the now-unnecessary ctlplane_vip key from the undercloud section in all 12 scenario files. The overcloud VIPs in vips_data.yaml files are unrelated and remain untouched. Depends-On: openstack-k8s-operators/ci-framework#4019 Related-Issue: #OSPRH-17418 Co-authored-by: Cursor <cursoragent@cursor.com>
5 participants
Summary
_ctlplane_vipvariable fromprepare_undercloud.ymlthat was set fromcifmw_adoption_osp_deploy_scenario.undercloud.ctlplane_vipos_net_config_undercloud.yml.j2andos_net_config_undercloud_bgp.yml.j2templates_ctlplane_ip— and the dependency OSPRH-12150 (TLS-e for adoption) is closed without needing itMerge ordering
This PR (consumer removal) must merge before the corresponding data-plane-adoption PR that removes the
ctlplane_vipkey from scenario files. If the scenario files losectlplane_vipfirst, the Ansible task referencingcifmw_adoption_osp_deploy_scenario.undercloud.ctlplane_vipwill fail with an undefined variable error.Test plan
checkpipeline passes (adoption jobs exercise these templates)Depends-Ononce that PR is createdRelated-Issue: #OSPRH-17418
Made with Cursor